search

ostreedev / ostree

Operating system and container binary deployment and upgrades
https://ostreedev.github.io/ostree/
Other
1.29k stars 296 forks source link

Add fsck --repair #959

Open untoreh opened 7 years ago

untoreh commented 7 years ago

would it be possible something like ostree pull --repair remote branch that fschecks the repository and pulls in corrupted objects?

cgwalters commented 7 years ago

See https://github.com/ostreedev/ostree/pull/345

cgwalters commented 2 years ago

A user hit a case where the current and previous commits were missing objects; ostree fsck naturally marked them both partial. Then doing e.g. ostree admin upgrade will pull the missing objects for the current commit but not previous. The problem is the prune bombs out looking for missing objects from the previous commit.

We do need to make it ergonomic to pull missing objects for all commits. Further, I think when we're going to delete a commit anyways we can just ignore missing objects.