Added different sort options, and fixed infinite runtime bug

ostrolucky / Simple-Subreddit-Image-Downloader

Bash script for downloading images posted in specific subreddit with minimal footprint

GNU General Public License v2.0

54 stars 6 forks source link

Added different sort options, and fixed infinite runtime bug #7

Closed makew0rld closed 4 years ago

makew0rld commented 4 years ago

I've added second and third arguments so that you can choose the sort of the page. The arguments aww top all will return the top posts of all time from r/aww, and aww new will start searching for images on the new page.

I also noticed that the script runs indefinitely, because the if [ -z $after ] check doesn't work, there will always be a value for $after. The correct bad value is null, so I added a check for that and it successfully exits now.

makew0rld commented 4 years ago

I've updated the README, and removed the extra condition. This PR now only adds functionality for sorting by page, and having different time scales for the top sort.

ostrolucky commented 4 years ago

merged in 0046879, thanks