search

ostroproject / meta-iot-web

Other
4 stars 9 forks source link

conf: Align layer name to directory name #47

Closed rzr closed 7 years ago

rzr commented 7 years ago

Rename layer name to "iot-web from "iotweb", to be used in collections.

This way this layer can be optionally and dynamicaly overloaded by sub layer, using this scriplet:

BBFILES += "${@' '.join('${LAYERDIR}/meta-%s/recipes//*.bb' % layer \ for layer in BBFILE_COLLECTIONS.split())}"

Signed-off-by: Philippe Coval philippe.coval@osg.samsung.com

ostroproject-ci commented 7 years ago

Can one of the admins verify this patch?

nagineni commented 7 years ago

LGTM.

Some modifications are needed in the Reference Kit [1] image configuration with this change, but those changes can be done when we update this repo as submodule in the Reference Kit.

[1] https://github.com/intel/intel-iot-refkit

pohly commented 7 years ago

@rzr The naming is better this way, but the suggested usage isn't going to work particularly well. It has ordering issues (sub-layer must come after base layer) and there are plenty of layers which do not follow this particular naming convention.

The solution chosen in bitbake master is BBFILES_DYNAMIC. Feel free to submit a backport patch for older releases.

rzr commented 7 years ago

Hi @pohly , that would help to get it merged, I am ready to help if there is any side effect too

rzr commented 7 years ago

Is it ok to keep this repo synced with intel/iot-web-layers at least until a new release of iotivity-node (2.x?) lands into it ?

nagineni commented 7 years ago

@rzr hi, I just merged this PR.

I do not have plans to test and maintain this repo in the future, so I recommend to switch to new one ASAP.