RTL-SDR support. - Githubissues

ostrosco / comms-rs

A library for building DSP communication pipelines.

MIT License

13 stars 1 forks source link

RTL-SDR support. #32

Closed ostrosco closed 5 years ago

ostrosco commented 5 years ago

Initial node for interfacing with the RTLSDR

Creating the initial node to provide an interface for collecting samples off the RTL-SDR tuner.
As the RTLSDR support requires a third-party library to be installed on the machine, we're making support for it optional. It can be enabled via the rtlsdr_support feature.
Clippy and rustfmt updates.

rfdoell commented 5 years ago

Quick sanity check - are most of these changes in other files just for formatting? If so, should they be broken into a separate commit/PR so it's more obvious the intent of this PR? (Or should I just not look :-P)?

rfdoell commented 5 years ago

Also, please check out #34 and tell me if it's worth waiting for this to be figured out before we start making more radio nodes.

ostrosco commented 5 years ago

Quick sanity check - are most of these changes in other files just for formatting? If so, should they be broken into a separate commit/PR so it's more obvious the intent of this PR? (Or should I just not look :-P)?

Yeah they could be. Typically I just run cargo fmt at top level before doing a commit. So it's mostly whitespace and minor formatting changes.

ostrosco commented 5 years ago

Also, please check out #34 and tell me if it's worth waiting for this to be figured out before we start making more radio nodes.

Yeah probably. Do we want to let this hang for now or do we want to figure out the Radio interface and update this node later?

ostrosco commented 5 years ago

Based on our discussion today, I'm gonna close this one and instead work on adding the radio traits.