search

osu-capstone-cs72 / cs-applied-plan-portal

A portal that streamlines the planning process for OSU CS Applied students and advisors
https://applied-plan-portal.herokuapp.com
MIT License
2 stars 5 forks source link

The first course selected when creating a plan never gives an error #39

Closed silverware13 closed 4 years ago

silverware13 commented 4 years ago

The first course selected on the create plan page always will be accepted and will not give an error.

philectron commented 4 years ago

Repro steps, expected and actual results?

silverware13 commented 4 years ago

Steps to reproduce: From home page go to create plan page. Search/filter CS courses. Press the "+ Add to plan" button on any course that should give an error (ex: CS261). Notice how no error appears, notice how it still gets added to the left panel. Try to add another plan with that should cause an error (ex: CS290). Notice that it gives an error correctly and is not added to the left side of the screen.

philectron commented 4 years ago

This has been fixed, yes? If so, can somebody make a PR?

clairecahill commented 4 years ago

Yes this issue is fixed but there is a question I have about the expected behavior of the filter bar. I was hoping to show you all at the meeting tomorrow before submitting the PR.

silverware13 commented 4 years ago

Sounds good, we can hold off on creating the PR until after our meeting.