MeController Refactor - Githubissues

osu-tournament-rating / otr-api

API powering osu! Tournament Rating

https://otr.stagec.xyz/

GNU General Public License v3.0

4 stars 2 forks source link

MeController Refactor #213

Closed myssto closed 3 months ago

myssto commented 3 months ago

Refactor of the me controller and related services pursuant to #207

Breaking changes:

UserInfoDTO changes
- Remove UserId field
- Change Id field to use o!TR id instead of osu! id
- Rename Roles field to Scopes
- Add PlayerId field for User.PlayerId

myssto commented 3 months ago

Yep I definitely managed to confuse myself along the way here, will give it another go through

myssto commented 3 months ago

Should have taken care of the type miss-matching stuff. If you could scrutinize this one a little more than usual for me because I can't seem to find any refactoring errors anymore, but I just want to be 100%

hburn7 commented 3 months ago

Awaiting approval before merge:

[x] https://github.com/osu-tournament-rating/otr-web/pull/144