Refactor Players Controller

osu-tournament-rating / otr-api

API powering osu! Tournament Rating

https://otr.stagec.xyz/

GNU General Public License v3.0

4 stars 2 forks source link

Refactor Players Controller #227

Closed myssto closed 2 months ago

myssto commented 3 months ago

Another one bites the dust

Breaking Changes

Change PlayerRanksDTO (Returns from /players/ranks)
- Add field string? username
- Add field string? country
- Rename field earliestOsuGlobalRank to earliestStandardGlobalRank
- Rename field earliestOsuGlobalRankDate to earliestStandardGlobalRankDate
Remove GET /players/id-mapping
Remove GET /players/country-mapping
Move GET /matches/player/{osuId} to /players/{key}/matches
Rename GET /players/all to /players
Rename GET /players/ranks/all to /players/ranks
Rename GET /players/{key}/info to /players/{key}

Additions

Add PATCH /players/{id}

Completes task Refactor PlayersController of #207 Closes #169 Closes #196

myssto commented 3 months ago

This is essentially a complete rewrite of the players route. If you depend on any of the endpoints, please be aware. I will open issues on processor and web soon. @AkinariHex @486c @S1n1st3rn3ss

hburn7 commented 2 months ago

This is essentially a complete rewrite of the players route. If you depend on any of the endpoints, please be aware. I will open issues on processor and web soon. @AkinariHex @486c @S1n1st3rn3ss

I know for a fact /players/id-mapping and /players/country-mapping are used by the processor. What is the plan for these?

Maybe just call all players?

myssto commented 2 months ago

I know for a fact /players/id-mapping and /players/country-mapping are used by the processor. What is the plan for these?

I thought I was told that they weren't... maybe we can discuss in dev? I know processor guys suggested better options or said that they were redundant in the first place

hburn7 commented 2 months ago

I know for a fact /players/id-mapping and /players/country-mapping are used by the processor. What is the plan for these?

I thought I was told that they weren't... maybe we can discuss in dev? I know processor guys suggested better options or said that they were redundant in the first place

Hm, okay. Still it'd probably be fine to just fetch all player data and make hashmaps from that instead of using these mapping endpoints.

myssto commented 2 months ago

Updated breaking changes section to better reflect changes to PlayerRanksDTO

myssto commented 2 months ago

Closing this for being way too big in scope. Will use as a reference for a piece-wise refactor of the players controller.