Disable lazy loading and use `AsNoTracking` for all table fetches

osu-tournament-rating / otr-api

API powering osu! Tournament Rating

https://otr.stagec.xyz/

4 stars 2 forks source link

Disable lazy loading and use `AsNoTracking` for all table fetches #297

Closed hburn7 closed 1 month ago

hburn7 commented 1 month ago

Closes #237

Disables lazy loading by default - this was causing the GetAllAsync repository methods to return ALL associated entities by default. Perhaps this is a reason for some of the performance issues I've noticed lately.
Use .AsNoTracking() for all of the GetAllAsync queries unless overridden.
Remove a useless GetAllAsync override in BeatmapRepository.

Depends on:

[x] #299

hburn7 commented 1 month ago

I'll do a large manual test of all processes just to make sure things are good. Bugs could easily get introduced through things like automated player fetching & updating. Want to make sure the change tracker is specifically enabled there.

hburn7 commented 1 month ago

Tested against otr-web master, all looks good.