osu-tournament-rating / otr-api

API powering osu! Tournament Rating
https://otr.stagec.xyz/
GNU General Public License v3.0
8 stars 5 forks source link

Warning flags for reviewers on various entities #411

Closed hburn7 closed 1 month ago

hburn7 commented 1 month ago

We need a way to flag games which use beatmaps that are only used once throughout the tournament. This is requested by @sourmongoose.

Edit:

This discussion will discuss the inclusion of warning flags that reviewers can look at during the review process. The idea is to get a brief glimpse into issues that do not necessarily warrant rejecting the item outright.

Confirmed flags:

myssto commented 1 month ago

I feel like there have been a lot of things that we identify for automation checks that result in the pre-rejection of an entity that we disagree on between a lot of people in the team. I'm wondering if we could expand on this and maybe have another flag enum, something like AutomationCheckSuspicions. I'm thinking it could be something that is sort of a half-way point between two points we have now being that if we want to identify something like this it would either have to create an entirely new and specialized property or be added to automation checks as a rejection reason. This way we could add some information about suspicious scenarios in entities that should be looked at more closely without having to necessarily pre-reject them outright.

hburn7 commented 1 month ago

I think having another field for flags as needed would be a great idea.

@cytusine0 / @SourMongoose I am curious what your thoughts are on this one. Are there any current rejection reasons that you feel should just be "flags" (alerts) instead? A flag in this case would not automatically mark the item as rejected, but would have some indicator during the review process.

myssto commented 1 month ago

Well it could also apply to things that we've axed from automation checks or that cytusine / sour weren't exactly the most keen on. For example we could reimplement the regex name check on matches, but it could be added to this new flag instead of being a reason to reject the match.

hburn7 commented 1 month ago

Yeah that's a great idea. Shall we make a feature tracking issue for this then? (Actually, we can just convert this issue into that)

myssto commented 1 month ago

I'd like to hear cytusine, sour, and alix opinions on this first but I'm on board. Mainly would like to hear as many use cases for this as possible. Mainly because this means that we will have to re-run automation checks on all tournaments now :D

SourMongoose commented 1 month ago

Wouldn't mind a separate "warning" flag, definitely see the regex check failing as part of this new flag then. Is there a full list of rejection reasons somewhere?

cytusine0 commented 1 month ago

The main other "useful flags" I can think of are

hburn7 commented 1 month ago

@cytusine0 First 1 I think is very doable. Perhaps just SR and duration are fine for now. The second one I don't think is very doable or practical. This would be something manual review covers, ideally.

In my head, these flags would be private to reviewers. I am unsure whether marking a tournament as 'verified' should remove these flags.

hburn7 commented 1 month ago

Wouldn't mind a separate "warning" flag, definitely see the regex check failing as part of this new flag then. Is there a full list of rejection reasons somewhere?

See here: