osu-tournament-rating / otr-api

API powering osu! Tournament Rating

https://otr.stagec.xyz/

GNU General Public License v3.0

8 stars 5 forks source link

Introduce `/tournaments/{id}:accept-pre-statuses` #521

Closed hburn7 closed 1 week ago

hburn7 commented 3 weeks ago

Part of #482

Introduces /tournaments/{id}:accept-pre-statuses endpoint which marks all pre- verification statuses as the verified equivalent.

github-actions[bot] commented 3 weeks ago

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked ☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [qodana-support@jetbrains.com](mailto:qodana-support@jetbrains.com) - Or via our issue tracker: https://jb.gg/qodana-issue - Or share your feedback: https://jb.gg/qodana-discussions

myssto commented 3 weeks ago

Also I'm not a fan of the name accept-pre-statuses. It doesn't directly reference a property like VerificationStatus like the proposed name does. I'll leave this one up to you

hburn7 commented 2 weeks ago

Nice work :D

I think it would be more productive if the endpoint returned the tournament since it's already in memory. This way frontend can update the status' of each entity immediately instead of requiring a refresh

Note that this returns the tournament with all child navigations, but yeah I'm fine to do this until it presents a problem.