osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
217 stars 131 forks source link

Maps with "gulag" as server enum are unexpectedly deleted #244

Open def750 opened 2 years ago

def750 commented 2 years ago

Maps with server 'gulag' get deleted from database (I tried in few different ways to stop this but only idea I had was wayyy to slow)

juup1ter commented 2 years ago

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

def750 commented 2 years ago

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

juup1ter commented 2 years ago

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

i guess this is per map basis then. i have a couple of maps i have deleted on bancho but are still ranked, about 2 weeks later.

def750 commented 2 years ago

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

i guess this is per map basis then. i have a couple of maps i have deleted on bancho but are still ranked, about 2 weeks later.

Maybe, idk but happened to around 8 maps on my server already where I had scores

tsunyoku commented 2 years ago

i don't know if you meant to word issue 1 like this, but when i deleted a map on bancho and checked it's status on the server, it keeps it's status like it was never deleted. is this what you meant?

Let's say you have some map that's graveyarded on bancho, you ranked it, and it has frozen = 1, then author decides to delete the map for whatever reason (from bancho), and boom your map get's deleted from your server's db.

this is intentional. freezing is to preserve statuses from updates, not make it immune from being unsubmitted. supporting unsubmitted maps is never going to work in a stable way - if the .osu file accidentally gets deleted or the db row get's messed up, there's no going back. and that's when you start to get api/lb errors

cmyui commented 2 years ago

Hey @def750 the 1st point is intended behaviour and won't be fixed

as for 2nd - is this issue specifically with qualified maps? or does this apply to all maps? is it only the ranked status not being updated, or all fields?

as for 3rd i'll have to investigate - were you trying to implement beatmap submission? also, could you split this into another issue so we can just focus this issue on the 2nd?

thanks! and sorry for the late reply 🥲

tsunyoku commented 9 months ago

first issue exists at #420 but second issue is still something with little info or predictability so i'm just gonna rename this issue for that specifically