refactor: implement repositories

osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python

https://akatsuki.gg

MIT License

212 stars 127 forks source link

refactor: implement repositories #495

Open 7mochi opened 1 year ago

7mochi commented 1 year ago

[x] Logs #484
[x] Map requests #485
[x] Comments #486
[x] Mails #487
[x] Ingame logins #489
[x] Client hashes #595
[x] Favourites #598
[x] Map ratings #599
[ ] User achievements
[x] Tourney pools #597
[x] Tourney pool maps #597
[ ] Players
[ ] Channels
[ ] Clans
[ ] Matches
[ ] API keys
[ ] User Relationships

NiceAesth commented 1 year ago

What is the direction you are going with the repository PRs? I see you changed the branch for them

7mochi commented 1 year ago

What is the direction you are going with the repository PRs? I see you changed the branch for them

~~I wanted to make another PR with all the repositories implemented~~ nvm

cmyui commented 7 months ago

I've created this PR as a reference for breaking up the collections modules, as they may be a bit trickier than usual:

https://github.com/osuAkatsuki/bancho.py/pull/597

This PR's description breaks down how we might approach players, channels, clans and matches similarly.

tsunyoku commented 7 months ago

just adding a note onto this about us refactoring existing repositories to sqlalchemy core (for query building), any further repos should be made in the same manor (use #632 as a good example of pretty much any usecase you might run into when writing the repos)