osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
213 stars 129 forks source link

Tests running in CI & score submission integration test #508

Closed cmyui closed 8 months ago

cmyui commented 1 year ago

Describe your changes

Related Issues / Projects

Checklist

cmyui commented 1 year ago

@tsunyoku do u know why i'm getting this mypy error?

tests/integration/domains/osu_test.py:14: error: Function is missing a return type annotation [no-untyped-def]

by my understanding mypy-tests.* should be covering this - and it's covering those under tests/unit..

https://github.com/osuAkatsuki/bancho.py/blob/58ef2b5bc79f3cdcb4bb66cab55465c95c5edfac/mypy.ini#L5-L7

cmyui commented 1 year ago

I don't think I'll merge this until it is backed by a temporary db.

tsunyoku commented 1 year ago

@tsunyoku do u know why i'm getting this mypy error?

tests/integration/domains/osu_test.py:14: error: Function is missing a return type annotation [no-untyped-def]

by my understanding mypy-tests.* should be covering this - and it's covering those under tests/unit..

https://github.com/osuAkatsuki/bancho.py/blob/58ef2b5bc79f3cdcb4bb66cab55465c95c5edfac/mypy.ini#L5-L7

i'm not sure how this plays with module paths over regular packages, i never really excluded via path with mypy before

tsunyoku commented 1 year ago

would also be nice to add a load leaderboard step before score sub to better test the real flow that would happen? would also be better for JITing the beatmap

cmyui commented 1 year ago

tests are passing in CI now