osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
201 stars 126 forks source link

feat: add mods to player.last_np #526

Closed minisbett closed 5 months ago

minisbett commented 10 months ago

Describe your changes

Adds the mods, which are already being parsed from the /np regex, to the player.last_np object.

Related Issues / Projects

Resolves #478

Checklist

cmyui commented 10 months ago

player.last_np is typed here as well - needs update

https://github.com/osuAkatsuki/bancho.py/blob/3a629386f1e8572b550becbd1f2558b1bbf23f4a/app/objects/player.py#L143-L146

cmyui commented 10 months ago

hmm mypy is not running on this pr - maybe cause it's on another repo? not sure

cc @tsunyoku

minisbett commented 10 months ago

player.last_np is typed here as well - needs update

https://github.com/osuAkatsuki/bancho.py/blob/3a629386f1e8572b550becbd1f2558b1bbf23f4a/app/objects/player.py#L143-L146

oh shit

tsunyoku commented 10 months ago

hmm mypy is not running on this pr - maybe cause it's on another repo? not sure

cc @tsunyoku

just checked, you limited the workflow to the push action which is indeed restricted to pushes on any branch in the main repo.

you can copy the rules from the other workflows - adding a pull_request action should fix it (you can still limit to *.py)

cmyui commented 10 months ago

adding a pull_request action should fix it

nice let me try ty

cmyui commented 5 months ago

+1 👍🏻