osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
201 stars 126 forks source link

chore: remove old (bugfix/migration) code #532

Closed minisbett closed 6 months ago

minisbett commented 10 months ago

Describe your changes

Removed various code that is either already old and commented out for a long time or presented updates for very old bancho.py times (e.g. when the country code wasn't saved yet) to clean up the codebase a bit.

Related Issues / Projects

Checklist

cmyui commented 9 months ago

i generally think prs removing backwards compatibilities are tricky to merge, it's kinda risky for low reward

cmyui commented 6 months ago

given they're pretty minor but can result in some pretty bad states i think i'm more comfortable leaving these for now.

i think i would be open to accepting a well tested script to backfill the data issues, at which point i would be willing to remove the jit data fixes here