osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
213 stars 128 forks source link

Gracefully handle no match host on lobby join case; add debug logs #600

Closed cmyui closed 7 months ago

cmyui commented 7 months ago

Describe your changes

There's an ongoing issue users have reported where host may not correctly resolve for an active match in the LobbyJoin packet. Multiple server owners (@minisbett, @HorizonCode, among others) have reported this issue on numerous occasions. I've never been able to replicate this, and I've traced the code and am not sure of the root cause.

image

This PR will stop the bleeding and not break players who encounter the issue, as well as logging to console (& my debug server if the server owner chooses to share this data with us).

I hope to more "correctly" resolve the information once we have the information to debug the issue.

Related Issues / Projects

Checklist