search

osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
213 stars 128 forks source link

Low-lift solution to move to stdlib logging #611

Closed cmyui closed 7 months ago

cmyui commented 7 months ago

Describe your changes

This PR moves us to working ontop of the standard library's logging module, as opposed to the current approach of rolling our own formatting to stdout. This adds a lot more flexibility. I intentionally made this change as a minimal-diff to avoid sweeping changes, but they will likely follow to give us further flexibility.

Related Issues / Projects

Resolves #266

Checklist

NiceAesth commented 7 months ago

oh nice this was one of the ones i had on my todo

tsunyoku commented 7 months ago

going to hold off on merging until we decide how we want to handle the breaking changes in this PR. obviously a message in #breaking-changes as standard, but i don't want to blindly merge this solo

cmyui commented 7 months ago

going to hold off on merging until we decide how we want to handle the breaking changes in this PR. obviously a message in #breaking-changes as standard, but i don't want to blindly merge this solo

I've reverted the breaking changes to .data/logs/chat.log. I think I'm going to change logging.yaml to logging.yaml.example though -- which will require users to cp logging.yaml.example logging.yaml at least.. That way they can make changes to the file without having it want to auto-include in every git push.