Closed cmyui closed 4 months ago
This is a terrible PR in terms of atomicity -- sorry for that -- but hopefully high value. Moving fast today.
My only gripe is the no internet check, can be very useful in certain situations. otherwise good PR
My only gripe is the no internet check, can be very useful in certain situations. otherwise good PR
👍🏻 I've re-added it
Describe your changes
This PR removes a couple of features:
SERVER_ADDR
andSERVER_PORT
config vars - now onlyAPP_x
variants exist_testing.runtime
main.py
(was only used for./main.py -V
)All of these seem like unnecessary complexity requiring extra maintenance overhead with low value delivered.
It also migrates more direct queries to SQL to instead use
players_repo
, removes usage of__all__
in modules, and more general cleanup.Related Issues / Projects
Checklist