osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
201 stars 125 forks source link

Remove unnecessary features to decrease maintenance/complexity overhead. + Cleanup & more repo usage. #612

Closed cmyui closed 4 months ago

cmyui commented 4 months ago

Describe your changes

This PR removes a couple of features:

All of these seem like unnecessary complexity requiring extra maintenance overhead with low value delivered.

It also migrates more direct queries to SQL to instead use players_repo, removes usage of __all__ in modules, and more general cleanup.

Related Issues / Projects

Checklist

cmyui commented 4 months ago

This is a terrible PR in terms of atomicity -- sorry for that -- but hopefully high value. Moving fast today.

TheFantasticLoki commented 4 months ago

My only gripe is the no internet check, can be very useful in certain situations. otherwise good PR

cmyui commented 4 months ago

My only gripe is the no internet check, can be very useful in certain situations. otherwise good PR

👍🏻 I've re-added it