osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
213 stars 127 forks source link

fix: catch pp wrong due to both acc and judgements specified #627

Closed minisbett closed 7 months ago

minisbett commented 7 months ago

Describe your changes

PP breaks on catch if both the accuracy and the 50s are specified. In VC we argued the best way to solve this is raising an exception in the usecase, and dropping specifying acc where possible, since it's a useless info.

This PR fixes catch PP, meaning bancho.py hosters will need to re-calculate all PP. Before doing this, I'd suggest looking into #573, as it improves the functionality of the recalc script and might be significant with this change.

Checklist

tsunyoku commented 7 months ago

bug fixes like this are really good candidates for adding unit tests to cover imo