osuAkatsuki / bancho.py

An osu! server for the generic public, optimized for maintainability in modern python
https://akatsuki.gg
MIT License
201 stars 125 forks source link

add level and level_progress to stats api routes #648

Open HorizonCode opened 3 months ago

HorizonCode commented 3 months ago

Describe your changes

Checklist

minisbett commented 3 months ago

I'm not sure whether this is a concern for bpy or whether a frontend should implement this itself

tsunyoku commented 3 months ago

level is a statistic so i don't have an issue with this being provided via API

7ez commented 3 months ago

tbh would be cooler if level and level progress would be combined

tsunyoku commented 3 months ago

i'm not convinced we need all 3. level being a float with the decimals being the progress should be enough

i don't particularly care which we pick, but either have level and progress separated or have them combined into one float. but not both

HorizonCode commented 3 months ago

then i would say keep level and level progress, bc for frotend dev its easier to use the values