search

osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
529 stars 79 forks source link

Refactor song menu #113

Closed ghost closed 3 years ago

ghost commented 3 years ago

Basically i followed my IDE to try to mitigate as many warns as possible in the menu classes, also simplified a piece of code in ModMenu.java, till now i didn't found any weird behaviours.

Rian8337 commented 3 years ago

Have you tested this? Sometimes refactor give undesired changes to functionalities.

ghost commented 3 years ago

ok

ghost commented 3 years ago

I tested the menus and applying settings etc and as it seens it's working properly, including querying and sorting beatmaps.