search

osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
506 stars 76 forks source link

Refactor cursor #116

Closed ghost closed 2 years ago

ghost commented 3 years ago

Basically "refactors" fl and cursor related things, and some other changes aswell.

ghost commented 3 years ago

actually i have found something odd

ghost commented 3 years ago

Wait i mean, adds custom fl delay, range = 120-1200

Rian8337 commented 3 years ago

Not a big fan of the delay on FL dim area following main cursor. It severely lowers Flashlight's playability when the player needs to move the cursor very fast.

ghost commented 3 years ago

In my oppinion this goes the other way, since there is a move animation when u click to a side to another, u can actually see something of what's happening on the screen and it looks more fun with streams, specially spaced ones.

Rian8337 commented 3 years ago

Doing this makes FL near impossible to play in very fast maps.

I strongly believe players will not like this change.

ghost commented 3 years ago

what about leaving it like that and if there is negative feedback coming towards the community make it optional but unranked (if fl will be ranked in the first place)

Rian8337 commented 3 years ago

what about leaving it like that and if there is negative feedback coming towards the community make it optional but unranked (if fl will be ranked in the first place)

You can ask people in the development Discord server to test.

Another point that I forgot to mention is this will show inconsistency in replays; in my opinion, this setting changes the difficulty of the mod, which should be reflected in replays, not per user setting.

ghost commented 3 years ago

I noticed that there are still moments that fl will not behave properly independent of having a nextobj or no.

Rian8337 commented 3 years ago

From a quick look, I think the color of mod customization text is too bright? Maybe a darker green can work since it's hard to read at the current state.

Rian8337 commented 3 years ago

I've replaced your auto cursor emulation with a new one that doesn't need to store all objects inside a separate list. It also fixes an issue where the cursor position would be wrong on stacked objects (because you didn't include position offset in original emulation). Test it for bugs if you'd like.

Still need to figure out why the cursor teleports to the left-corner of the screen for a brief moment before it starts spinning a spinner.

Rian8337 commented 3 years ago

I haven't gotten time to look at this, but I think the auto cursor emulation can also be applied for AP mod and not just Auto (it's called an "auto-based cursor" for a reason, anyway).

Rian8337 commented 2 years ago

Superseded by #143.