osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
507 stars 76 forks source link

Skin folder reads skin assets #164

Closed ZZdashX closed 1 year ago

ZZdashX commented 2 years ago

osudroid reads assets from Skin folder for some reason.

Setting my own skin as default skin: Screenshot_2021-12-23-23-07-41-04_846b44643ec609f507828878741e1f9a

Skin set: default Screenshot_2021-12-23-23-12-17-19_41e4bcfddb1ad8126986d42329ac2750

Screenshot_2021-12-23-23-12-55-02_41e4bcfddb1ad8126986d42329ac2750

Beyley commented 2 years ago

This is intentional

ZZdashX commented 2 years ago

i mean, the game reads assets from the Skin folder which overwrites some default stuff

Untitled122_20211223234245

In this case, if your skin has a missing combobreak.wav element this will took over

Beyley commented 2 years ago

i mean, the game reads assets from the Skin folder which overwrites some default stuff

Untitled122_20211223234245

In this case, if your skin has a missing combobreak.wav element this will took over

yeah thats an intentional feature

ZZdashX commented 2 years ago

i mean, the game reads assets from the Skin folder which overwrites some default stuff Untitled122_20211223234245 In this case, if your skin has a missing combobreak.wav element this will took over

yeah thats an intentional feature No it's not The purpose of this folder is to read skin folders, not skin elements w

Beyley commented 2 years ago

i mean, the game reads assets from the Skin folder which overwrites some default stuff Untitled122_20211223234245 In this case, if your skin has a missing combobreak.wav element this will took over

yeah thats an intentional feature No it's not The purpose of this folder is to read skin folders, not skin elements w

This feature carries back to pre 1.6.6(?) builds where there were no skin folders, rather a single one (its why the folder is called Skin not Skins) It still pulls from the root Skin folder for backwards compat, im sure there are a lot of old players who sitll use the legacy skin scheme so chaning it is a terrible idea right now

ammarasyad commented 2 years ago

this is entirely intentional

ZZdashX commented 2 years ago

o

Beyley commented 2 years ago

since this is intentional, can someone close this issue?