search

osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
507 stars 76 forks source link

Add restart dialog when toggling dither #175

Closed ammarasyad closed 2 years ago

ammarasyad commented 2 years ago

Toggling dithering on or off without a restart (closing the game directly from the recents list) may cause a crash on certain devices when closing options; this PR adds a restart dialog when toggling the option.

Pressing "ok" will restart the game, while pressing/swiping back will not restart the game, nor will it crash when closing options (tested this on my phone, which prior to this addition/fix, the crash was easily reproduced), as the change will apply at restart. Toggling back the option to its initial value (let's say, on -> off -> on) won't display the dialog.

While I'm at it, I changed the dithering option's description to be... more descriptive.

ammarasyad commented 2 years ago

So it seems that the crash is unrelated to the dithering change. I'll still leave this up for the sake of user convenience.