osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
498 stars 74 forks source link

General performance and memory usage improvements #316

Closed ammarasyad closed 3 months ago

ammarasyad commented 5 months ago

Continuing on the last PR by Reco1l, I decided to incorporate some of his changes to the current osu!droid codebase, with some of my own changes. As this will bring a large change, this will require extensive testing to ensure stability. Report any performance regressions, bugs, or unexpected changes in gameplay.

This PR is mostly a work-in-progress, as I iron out bugs, edge cases, and potential compatibility issues that may arise from the changes. In the meantime, if you wish to help and is able to build osu!droid, please test from my branch. Any input is appreciated.

ammarasyad commented 3 months ago

Mostly looks good. I have not tested multiplayer yet, since there appears to be multiplayer changes. However, I'm not sure if the change towards speed modify bar (having to check the box first before dragging the slider) is intended, but it brings parity with force difficulty statistics, so I will leave it be.

It is intended. I didn't find the current behavior in release intuitive, so I changed it myself.