search

osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
498 stars 74 forks source link

Fix wrong textures being displayed before in-game video plays on certain devices #325

Open ammarasyad opened 3 months ago

ammarasyad commented 3 months ago

This PR fixes #318.

Upon research across 2 devices and 2 emulators, it seems that there is possibly a bug in Mali GPUs' drivers that causes the wrong texture to be displayed before the beatmap's video starts, if present. The texture displayed is consistent across multiple gameplays, differing only whether the scoreboard is shown or not. This behavior is not present in Snapdragon devices and Android emulators, thus leading to the suspicion that Mali drivers are at fault.

Reco1I commented 3 months ago

What's up, just a suggestion: Calling the driver at every draw call to get the renderer information can be a little of bit unnecessary. This should be done once (I'd do at the first draw call of the texture) and work with that.

ammarasyad commented 3 months ago

What's up, just a suggestion: Calling the driver at every draw call to get the renderer information can be a little of bit unnecessary. This should be done once (I'd do at the first draw call of the texture) and work with that.

You're right, I overlooked that. Thanks for the suggestion.