osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
498 stars 74 forks source link

enable workflow_dispatch and attach debug APK for Android CI #339

Open cattokomo opened 2 months ago

cattokomo commented 2 months ago

Closes #335

Changes to Android CI (android.yml):

Rian8337 commented 2 months ago

Is there a reason for running the workflow on every push?

cattokomo commented 2 months ago

Is there a reason for running the workflow on every push?

It's already there since I made the workflow to attach artifacts, perhaps I need to restrict on certain path?

Rian8337 commented 2 months ago

Apologies, I meant to ask about the artifact part.

cattokomo commented 2 months ago

If you meant why is it need to be attach with APK artifact, see the issue I referenced.

Rian8337 commented 2 months ago

I understand why, but I don't understand why the APK artifact must be attached on every push or pull request.

cattokomo commented 1 month ago

There's no reason to it, other than being faster way to build the APK and test it right in your phone whether. I can restrict it to only attach when pushing/making PR on specific path, or restrict it at all and only attach if it's triggered by workflow_dispatch event.

Rian8337 commented 1 month ago

or restrict it at all and only attach if it's triggered by workflow_dispatch event.

I think that would suffice. There may be cases where a commit should not be tested publicly (i.e., incomplete implementation of a feature), so it should be opt-in.

cattokomo commented 1 month ago

Then disabling it via commit message could work, such as noci or skipci at the end of commit message.

Rian8337 commented 1 month ago

so it should be opt-in.