search

osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
498 stars 74 forks source link

Some GameScene class refactor and simplification. #341

Closed Reco1I closed 1 month ago

Reco1I commented 2 months ago

In this PR I refactoring and fixing some IDE warnings over GameScene class.

Additionally a helper method is added to GameMod class which is intended to return the corresponding texture key for the mod icon.

Rian8337 commented 2 months ago

I have a hunch that this will change the view order of mod icons in gameplay, but it doesn't matter as long as all mods are displayed, so let's go with it.

Reco1I commented 2 months ago

I have a hunch that this will change the view order of mod icons in gameplay, but it doesn't matter as long as all mods are displayed, so let's go with it.

Yes I thought that too, in this case the order will be the declaration order in GameMod enum.