search

osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
551 stars 78 forks source link

Force AR and speed modify modifiers should stored in replays #37

Closed EdrowsLuo closed 4 years ago

EdrowsLuo commented 4 years ago

Is it intentional that force AR and speed modify modifiers are not stored in replays? Apparently they are only stored in score database file.

Originally posted by @Rian8337 in https://github.com/osudroid/osu-droid/issues/29#issuecomment-704652710

Rian8337 commented 4 years ago

Not intentional, but when I try to stored them in replays, new replays will can't be read by old version osu!droid(before this change, some replay can be read by old version). Shall I store them in replay?

@None1637 yes, you should. Edrows has told you in #29 about how to solve that issue. Additionally, if you intend to make this ranked in the future, storing them in replays are required.

None1637 commented 4 years ago

Not intentional, but when I try to stored them in replays, new replays will can't be read by old version osu!droid(before this change, some replay can be read by old version). Shall I store them in replay?

@None1637 yes, you should. Edrows has told you in #29 about how to solve that issue. Additionally, if you intend to make this ranked in the future, storing them in replays are required.

That issue(If I stored them in replays, old version can't read new version replay) can't be solve. But I will store them in replay at next PR

EdrowsLuo commented 4 years ago

Solved in #38