osudroid / osu-droid

http://osudroid.moe
Apache License 2.0
506 stars 76 forks source link

Added shrink flashlight area when sliders are holded, similar to osu!std fl. #73

Closed ghost closed 3 years ago

ghost commented 3 years ago

Just to add here, still not done, i will try to make some things better.

ghost commented 3 years ago

It's done, it isn't nothing too complex anyways.

EdrowsLuo commented 3 years ago

It seems like a rough approch of flash light of osu!std. If you want to want fl works in the same way osu!std does, maybe you should refer to the code of osu!lazer, but not simply guess some values.

None1637 commented 3 years ago

I check the FL mod's code in osu!lazer. https://github.com/ppy/osu/blob/master/osu.Game.Rulesets.Osu/Mods/OsuModFlashlight.cs

// If a slider is in a tracking state, a further dim should be applied to the (remaining) visible portion of the playfield over a brief duration.

There is no change in the size of the visible area.

ghost commented 3 years ago

Oh, I will try to figure out a way to do with a dim version later then. Thanks.

ghost commented 3 years ago

Eh, i can't really do it, i think i will put learn java in my goals, i rlly want to contribute something for this game...