search

osulp / Room-Reservation

OSU Libraries & Press Room Reservation System
GNU Affero General Public License v3.0
6 stars 5 forks source link

Add support to pull special hours with multiple hours blocks from Alma api #339

Closed luisgreg99 closed 4 years ago

luisgreg99 commented 5 years ago

Descriptive summary

From asana:

Open Room does not appear to be pulling hours from Alma. A student was trying to make a
reservation for dead week and it said all the rooms were closed. I am manually plugging in hours for the rest of the month until we can get a fix. I am concerned that reservations previously placed during this time period have been wiped out. Or I just didn't see the mess earlier? I don't know.

Expected behavior

During special hours, room reservations should show as "open" or "close" based on special hour blocks (they could be multiple) from OSULP API instead of the standard hours. It could pull from https://github.com/osulp/API/blob/master/app/services/api/open_and_special_hours_xml_to_json_parser.rb#L278

Actual behavior

Hours that occur during special hours show up as closed when it should be open.

Steps to reproduce the behavior

  1. Go to http://rooms.library.oregonstate.edu/day/2019-3-17
  2. Select 2019-3-17 from the calendar if it's not selected by default
  3. Pick a room and make a reservation in the afternoon (i.e 4PM)

Related work

The workaround for now is to add these special hours in the 'Cleaning Schedule'.

Related work from the api. https://github.com/osulp/API/pull/71