search

osulp / Room-Reservation

OSU Libraries & Press Room Reservation System
GNU Affero General Public License v3.0
6 stars 5 forks source link

update the gem sass-rails to version 6 #355

Open KennaW opened 4 years ago

KennaW commented 4 years ago

Sass-rails 4 is running EOL ruby sass

https://github.com/osulp/Room-Reservation/blob/master/Gemfile#L22

Sass-rails 6 update should take care of it.

if the sass-rails update breaks the css, just leave it on a branch and I (Kenna :) ) will fix the css there

luisgreg99 commented 4 years ago

I tried to upgrade to gem 'sass-rails', '~>6.0', and I found that it also requires at least sprockets 3.7.2. I pushed the update in this branch upgrade/sass-rails-from-2-to-6 for testing

It looks like sass-rails should be automatically updated to 6 with https://github.com/osulp/Room-Reservation/pull/354, which was recently posted by GitHub dependabot. This updates sass-rails to 6 and sprockets to 4, but it also does a rails upgrade from 4.2.11 to 5.2.4.1. I think https://github.com/osulp/Room-Reservation/pull/354 should resolve this update, but it needs additional changes since rails 5 requires these updates to the codebase to bump to rails 5: https://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-4-2-to-rails-5-0