Cannot add existing collection as subcollection

osulp / Scholars-Archive

ScholarsArchive@OSU, institutional repository for Oregon State University

https://ir.library.oregonstate.edu/

14 stars 3 forks source link

Cannot add existing collection as subcollection #2629

Closed simholt closed 3 months ago

simholt commented 4 months ago

Descriptive summary

Because of a name change, I'm trying to add Undergraduate Research, Scholarship, and the Arts (URSA) as a subcollection to the Office of Undergraduate Research (OUR) collection. I keep getting error messages. I tried with other colls and those didn't work either.

Expected behavior

Can add collections as subcollections to existing collections.

Actual behavior

Steps to reproduce the behavior

From a collections dashboard view (?), example, click Add a subcollection.
Choose a dropdown from the menu.
Get error message.

simholt commented 4 months ago

A populated dropdown appeared (that's new!) and I selected a collection but nothing happened. I clicked the Add a subcollection button multiple times and eventually an error message appeared. Tried multiple times.

straleyb commented 4 months ago

So when you click the button to add a subcollection to a collection, it has no feedback (out of the box functionality from Hyrax). If you just click the button once and then give it a minute or two, it actually is processing in the background. This can most definitely be enhanced user experience wise.

This GIF is a minute long so its a tough one. But I added Cara's Collection to A Nice Collection

simholt commented 3 months ago

I clicked to add a subcollection and let it run for seven minutes and nothing changed (screenshot below). The box did not disappear as in the gif above.

I clicked around and the window disappeared and the subcollection had been added. I tried with another subcollection addition but didn't wait as long and it also was added.

Can we have it so the Add a subcollection button greys out and it closes when the task is done?

straleyb commented 3 months ago

@simholt This should be ready for QA now.

Note: It'll disable the button and close the popup window. You'll still have to refresh the page to see the update, but there is an alert that pops up saying that the action is being processed in the background.

simholt commented 3 months ago

Great! QA pass ---

simholt commented 3 months ago

@straleyb Did this get pushed to production? It isn't working for me.

straleyb commented 3 months ago

@simholt I think it did. On production, when I go to a collection page and click the add subcollection button, I get this view. Are you able to have the dropdown on the popup window to choose the subcollection?

simholt commented 3 months ago

Yes, that shows, but I choose one and nothing happens. I did not get the same alert about processing in the background like I did on staging. Tried a few times, waited 5+ minutes.

straleyb commented 3 months ago

I think I have to recompile the javascript. I think I did it on staging but not after the production deploy. Let me run that and ill ping here when it is complete.

straleyb commented 3 months ago

Alright give it another go @simholt

simholt commented 3 months ago

Okay -- I logged in and the first collection I was trying to add showed up correctly as a subcollection. I tried another (adding Library Undergraduate Research Awards as a subcollection to the University Libraries collection) and while the working-in-background popup showed, the subcollection was not added.

simholt commented 3 months ago

Okay -- looks like I need to give this process more time! It works!