search

osulp / Scholars-Archive

ScholarsArchive@OSU, institutional repository for Oregon State University
https://ir.library.oregonstate.edu/
14 stars 3 forks source link

Geonames location not resolving on show page #2658

Closed simholt closed 1 month ago

simholt commented 2 months ago

Descriptive summary

You can add Geonames locations to a record and it saves fine (and shows up in limiters) but it doesn't appear on the show page. They were showing sporadically before the upgrade but now they don't show up at all.

Expected behavior

Geonames location info listed on show page.

Actual behavior

It's associated with the work but you can't see it unless you view the edit page. Example: https://ir.library.oregonstate.edu/concern/defaults/qf85nk58b

Steps to reproduce the behavior

  1. Add something to a location field - like this one: gt54kw13k Save.
  2. View the record -- nothing there.
  3. Click edit button and oh look the field is filled out.
  4. Please remove your change!
lamtu1 commented 2 months ago

Hi @simholt, I just checkout the link you mention in this ticket, below is the screenshot on my end of what I see and it is displaying the location correctly.

Image

And I also did a test on my local env, when I first created the work, it didn't appear and waited for couple minutes until it process and refresh the page, and the location appear for me (another screenshot below) and was wondering if it is not showing still for you on your end?

Image

simholt commented 2 months ago

qf85nk58b That one shows for me now! I don't know what changed?

However, all the others I checked that have locations -- like all these -- the location is not showing up. I tried re-saving it & waiting a while, deleting the location then re-entering, and still nothing.

lamtu1 commented 2 months ago

Hmm I see it too that some of the location is not showing up with the one you mention, I will have to dive deep into it and see what I can do

lamtu1 commented 2 months ago

UPDATE: Discover that the geoname location is using sidekiq worker to perform solr indexing which it will take a couple minutes (roughly 1-2 min) to be index and the display will show up after waiting a couple minutes and refresh the page to see the change.

simholt commented 1 month ago

@lamtu1 Q: So it sounds like we will need a reindex for locations to show up on existing records?

Image

A couple things:

  1. Can we make it so any extra comma/space combos don't show up? Should be just one comma and one space between terms. AND get rid of the comma at the end.
  2. We do not want the info in parenthesis showing.

Related:

1694

lamtu1 commented 1 month ago

@lamtu1 Q: So it sounds like we will need a reindex for locations to show up on existing records? Yes, I think a reindex should be a good thing for the location to re-appear up for those area or do a re-save on all of the work should also do the trick as well. And yes I will try to filter out the parenthesis and any other areas you pointed out based on the string

lamtu1 commented 1 month ago

Hi @simholt, do you want these areas on SA to be change as well and have it follow the format you wanted on the show page? or just the show page itself only?

Image Image

simholt commented 1 month ago

@lamtu1 Yes, they all should have the same structure.

simholt commented 1 month ago

https://ir-staging.library.oregonstate.edu/concern/articles/h128nd88s

Looks good! QA pass