search

osulp / Scholars-Archive

ScholarsArchive@OSU, institutional repository for Oregon State University
https://ir.library.oregonstate.edu/
14 stars 3 forks source link

Provide page title value for Work and File Analytics pages, to match text in h2 #452

Closed wickr closed 7 years ago

wickr commented 8 years ago

Currently the page title for http://ir-staging.library.oregonstate.edu/files/8623hx72q/stats is "File Stat // Sufia". "File Stat" should probably match "File Analytics" that is in the h2.

Because we don't provide a page_title value, I think Curation Concerns is just using a default page value from the controller name: https://github.com/projecthydra/curation_concerns/blob/71f0b9d8b210a7833eefdf333bfeb8859e255c56/app/helpers/curation_concerns/title_helper.rb#L18

zhang4952 commented 7 years ago

As shown with this sample: http://ir-staging.library.oregonstate.edu/files/v405s938k/stats, the page title is File Stats // Hyrax now. But I also see that same pattern use for many other views, such as http://ir-staging.library.oregonstate.edu/concern/parent/t722h8817/file_sets/v405s938k, the page title is 'Show File Set // Hyrax'. I suspect the pattern is by default from curation_concerns, should we customize it? @wickr ?

zhang4952 commented 7 years ago

Correction, page title as shown with this sample: http://ir-staging.library.oregonstate.edu/files/v405s938k/stats, is still 'File Stats // Hyrax'. But I also see that same pattern used for many other views, such as http://ir-staging.library.oregonstate.edu/concern/parent/t722h8817/file_sets/v405s938k, the page title is 'Show File Set // Hyrax'. I suspect it is by default from curation_concerns, should we customize all the views?