search

osuosl-cookbooks / pgd

Apache License 2.0
1 stars 0 forks source link

Misc bug fixes from the recent merges. #20

Closed pop closed 7 years ago

pop commented 9 years ago

I was getting a few errors when trying to converge the cookbook and this PR should fix those errors.

  1. Testing was broken between local and openstack instances of the cookbook. This was probably just an oversight of mine but I added separate test suites for local and openstack deployment.
  2. There were a few small errors in bootstrap_user.rb (DJANGO_SETTINGS_MODULE being incorrectly set was the largest one) so I fixed those.
  3. There was a pathing issue in so I corrected that.
  4. .kitchen.cloud.yml and .kitche.yml had some attributes which needed to be modified since we are placing everything in /opt instead of $HOME.
armiller commented 9 years ago

Other than that one nit LGTM.

mathuin commented 9 years ago

So I checked out the branch and ran tkc test and it passed. I then ran kitchen test and it passed. I'm ambivalent on @armiller's nit. +1

mathuin commented 9 years ago

I reran both tests. They both passed. +1

armiller commented 8 years ago

Whats up with this pr? Does it still need to be merged?

armiller commented 8 years ago

ping again

mathuin commented 8 years ago

In attempting to test this, I discovered that my kitchen configuration is apparently out of date.

This is what I get when I run kitchen converge:

-----> Starting Kitchen (v1.6.0)
$$$$$$ No platforms supported in metadata.rb;showing all available platforms
[2016-05-12T15:30:18-07:00] WARN: Ohai::Config[:log_level] is set. Ohai::Config[:log_level] is deprecated and will be removed in future releases of ohai. Use ohai.log_level in your configuration file to configure :log_level for ohai.
[2016-05-12T15:30:18-07:00] WARN: Ohai::Config[:log_location] is set. Ohai::Config[:log_location] is deprecated and will be removed in future releases of ohai. Use ohai.log_location in your configuration file to configure :log_location for ohai.
>>>>>> ------Exception-------
>>>>>> Class: Kitchen::UserError
>>>>>> Message: Kitchen::Driver::Openstack<local-centos-67>#config[:private_key_path] cannot be blank
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

Is there something obvious I'm missing?

armiller commented 8 years ago

Check to see if you env vars match this: https://docs.osuosl.org/software/openstack/openstack_test_kitchen.html#environment-variables and try again.

mathuin commented 8 years ago

After some tweaking with my environment I was able to get the Openstack test kitchen stuff working.

The PGD code base has moved past the point where this PR can work. I'm going to examine it in detail -- and the other outstanding PR on the similar topic -- to determine what if anything can be repurposed into a new PR.

ramereth commented 7 years ago

@mathuin shall we just go ahead and close this then?

mathuin commented 7 years ago

@ramereth Right now, I would say yes. The codebase had a reorg and it's due for another once the scientific changes are approved. Those architectural changes are significant enough that it will break the cookbook pretty hard.

I recommend we close this issue, and defer any cookbook-related issues until a plan is in place to migrate PGD off of zeus. It's likely that by that time, we'll be on whatever comes after chef. :-)