search

osuosl-cookbooks / rdiff-backup

Chef cookbook for automating the deployment of rdiff-backup
Apache License 2.0
5 stars 1 forks source link

Store existingjobs as attribute rather than reparsing cron file? #31

Open rettigs opened 9 years ago

rettigs commented 9 years ago

Doing this would eliminate the error-prone parsing of /etc/cron.d/rdiff-backup in order to get a list of jobs that are already present on the rdiff-backup server.

jordane commented 9 years ago

Why do you need to store existing jobs? If a job isn't in chef, it has no place being on the server.

rettigs commented 9 years ago

@jordane The reason to store existing jobs was so that during a new Chef run, it could detect which jobs were on the filesystem but not specified in Chef, so that it could remove them from the filesystem; in particular, using the Nagios NRPE LWRP required this in order to call the :remove action on that job's check. However, as mentioned in https://github.com/osuosl-cookbooks/rdiff-backup/pull/13#issuecomment-106578284, I could just delete the created files manually rather than using the :remove action in the LWRP, meaning that the existing jobs would no longer need to be stored.

So basically, this issue should be moot.