search

osuosl / dougfir-pelican-theme

Pelican theme based off of the OSU Dougfir Drupal theme
Apache License 2.0
2 stars 2 forks source link

Minor fixes #51

Closed athai closed 8 years ago

athai commented 8 years ago

The table on the Partner With Us page now looks like this. cass_partners_table

As for the slide show, it seems that removing it entirely (on mobile) may be the better option. The following are a list of issues a mobile slide show has:

Alternatively, I think it'd be better to switch to a static image and default title once we hit a certain pixel width. Currently, the web page is set up to do exactly that, but since we haven't specified an image/title to use, it's defaulting to the most recent article and its image.

There are two options as to what we can use as the default mobile image.

  1. The CASS staff image
  2. A collage of images from the 5 featured articles

Option 1 is easiest since it probably won't need to be updated regularly. Option 2 will take some work to maintain, but if we go with a collage, I can still make it link to News (like the All Stories button did). So even though the mobile site may be visually different from the regular website, it'll still be somewhat similar functionally.

What do you think?

@kelnera @Kennric

leian7 commented 8 years ago

+1

kelnera commented 8 years ago

+1

On Wed, Aug 31, 2016 at 2:49 PM, leian7 notifications@github.com wrote:

+1

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/osuosl/dougfir-pelican-theme/pull/51#issuecomment-243913593, or mute the thread https://github.com/notifications/unsubscribe-auth/AOTrIaJ1fDioz7RfmU77PsMs46dQaLeBks5qlfb-gaJpZM4JyC1z .

subnomo commented 8 years ago

@athai Why is the slideshow so broken on mobile? I haven't looked too much into it, but we're using slick.js, correct? The site says it's fully responsive. If that doesn't work, why not just swap out for another library?

I just feel like the slideshow is a large part of the home page, and it would be better to repair it than to remove it, especially considering how most web traffic comes from mobile devices nowadays.

kelnera commented 8 years ago

@athai @subnomo Pam reminded me that the slideshow on the EECS website works just fine on mobile. Is there a way to access the Drupal template and see if we can't translate that to the Pelican site? Or am I oversimplifying things?