Mrsj/formatpages - Githubissues

osuosl / dougfir-pelican-theme

Pelican theme based off of the OSU Dougfir Drupal theme

Apache License 2.0

2 stars 2 forks source link

Mrsj/formatpages #6

Closed matthewrsj closed 9 years ago

matthewrsj commented 9 years ago

Significant changes made to dougfir-pelican-theme, including:

Added images to path
Modified and added to CSS to improve formatting
Added blog-sidebar.html to includes for custom sidebar when in article or blog page
Began to work on cleaning up CSS by adding
- main.css
- header.css
- footer.css
- mainmenu.css
- sidebar.css
I began populating these with CSS from the old styles but they are not yet included in the HTML.

matthewrsj commented 9 years ago

@Kennric

ramereth commented 9 years ago

Why does the theme include site specific images? That should only be in the ousosl-pelican repo, not the theme itself. The theme should only contain the common images that are needed for the theme itself.

Kennric commented 9 years ago

search removal looks fine, no errors intorduced.The code here looks good, but I can't comment on the content as much. +1

matthewrsj commented 9 years ago

@jordane

ramereth commented 9 years ago

Good enough for now. I'm sure there are more edits to be fixed but this PR is big enough as it is. Great work! :+1: