osuosl / dougfir-pelican-theme

Pelican theme based off of the OSU Dougfir Drupal theme
Apache License 2.0
2 stars 2 forks source link

Update Header #79

Closed athai closed 7 years ago

athai commented 7 years ago

Note, there are some issues that I couldn't figure out/resolve:

kelnera commented 7 years ago

@athai Thanks for your hard work! I can only answer a couple of these concerns. The CASS website will quickly be back on drupal (probably within the next week) so don't worry about issues with that site. Just make sure things look good for the OSL website. If you go to #78 there's a link to the branding pages and on the font page, they have alternative options for all three new fonts. I'll work on getting the official ones, but this should suffice for now.

ramereth commented 7 years ago

@athai looks like a great start! A few comments/answers

Kennric commented 7 years ago

@ramereth you can see the results of my changes here: http://osuosl-pelican-175.staging.osuosl.org

kelnera commented 7 years ago

Great progress! I have a few more things I noticed:

Hopefully most of these are easy changes, although that last one might take more time so I won't ask that be fixed before we merge these changes; just something to keep an eye out for while you'll already be in the theme. Getting closer!

Kennric commented 7 years ago

@ramereth, @kelnera I've updated a couple of things, the color and >> character, but the font EECS is using is a commercial font we don't want to add to the repo. I have not figured out the slideshow breakage on resize yet, and it might not be easily fixable - also it's a fairly edge case, I don't think users frequently resize while looking at the front page.

http://osuosl-pelican-175.staging.osuosl.org

kelnera commented 7 years ago

@Kennric Looks better and I think we're close. I knew the new fonts were specifically for OSU and they're not accessible to the public (or easy to download) so it's nice they've offered the alternative fonts. I think the only thing I would like to change before merging is applying the Impact font (alternative to Stratum 2) to the page headers and the blog feed. But I also know we're on a time crunch so if we need to push as is we can just make an issue.

ramereth commented 7 years ago

@Kennric I think this is basically ready for desktops, but on mobile or responsive it seems to have a few issues specifically in the header section. There also seems to be quite a bit of white space from the image banner to the text below:

screenshot from 2017-07-27 08-48-00

In comparison, the EECS website looks like this:

screenshot from 2017-07-27 08-49-41

ramereth commented 7 years ago

@JerryPeng0112 please feel free to merge this and then create a new PR which merges develop into master.