Lint and update all of the files - Githubissues

osuosl / fenestra

A dashboard displaying stats about the OSU Open Source Lab

Apache License 2.0

2 stars 3 forks source link

Lint and update all of the files #55

Open MorganEPatch opened 7 years ago

MorganEPatch commented 7 years ago

This is a change that I think this project has been desperately waiting for.

Changes in this PR.

[X] Update rubocop and lint all ruby code
[X] Upgrade all JS code to ECMAScript 6
[X] Introduce the official OSL JSHint standard
[X] Introduce the official OSL ESLint standard
[X] Lint and fix all JS files as best as possible for the project's structure
[X] Clean up the HTML and SASS files.

Testing this PR.

As a refactor commit, this should cause NO change in functionality. To test, just run and make sure nothing broke.

Expected Output.

@osuosl/devs

Kennric commented 7 years ago

@LyonesGamer so... is the upgrade to ECMAScript 6 going to break fenestra on Safari? Not that we use Safari now, but if this is expanded into a more general dashboard our clients can view, we should keep that in mind. Maybe a compatibility message if the app detects safari?