Refactor and Comment Formsender

osuosl / formsender

Simple script to email form submissions.

Apache License 2.0

3 stars 1 forks source link

Refactor and Comment Formsender #26

Closed matthewrsj closed 9 years ago

matthewrsj commented 9 years ago

Considerable refactor of Formsender, especially Forms.on_form_page()
Docs modified to reflect removal of test form access from formsender.
Several comments added to function to explain application logic.

Kennric commented 9 years ago

This is looking great, a big improvement in readability and more idiomatic python. Tests are passing, and I'm not seeing any major issues, but it's such a big PR, I think it would be a good idea to get a second opinion.

matthewrsj commented 9 years ago

@Kennric woah, that last commit just broke an unrelated test on Travis. Tests still working locally...

Kennric commented 9 years ago

oops - I was writing my comment while you were commiting, I guess

matthewrsj commented 9 years ago

i'm rebuilding, that shouldn't have broken anything

matthewrsj commented 9 years ago

Ok... strangely... that worked.

Looks like the test timed out in Travis for some reason.

Kennric commented 9 years ago