osuosl / formsender

Simple script to email form submissions.
Apache License 2.0
3 stars 1 forks source link

Add more logging info #60

Closed athai closed 8 years ago

athai commented 8 years ago

WIP #51.

Note: https://github.com/osuosl/formsender/pull/60/files#diff-0c3b79f514f76d507ede2c77ae608833R135 may need to be changed after form field(s) naming conventions are discussed.

matthewrsj commented 8 years ago

@athai this looks correct. Can you add the log output of a test run as a comment so we can be sure it is logging correctly?

athai commented 8 years ago

@matthewrsj What do you mean?

matthewrsj commented 8 years ago

@athai this is what I'm talking about: https://github.com/osuosl/formsender/pull/42

I can help with this later.

athai commented 8 years ago

@ramereth Formsender now logs the full request at level DEBUG. After running tests, logs can be found in /var/log/syslog. The following is an example of (part of) the output.

Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: name is: Valid Guy Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender: sending email from: example@osuosl.org Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'} Mar 30 11:45:05 silver DEBUG formsender message: {'redirect': u'http://www.example.com', 'token': u'15674hsda//q23%^13jnxccv3ds54sa4g4sa532323!OoRdsfISDIdks38(dsfjk)aS', 'last_name': u'', 'name': u'Valid Guy', 'email': u'example@osuosl.org'}

matthewrsj commented 8 years ago

It should be mentioned that this is some of the output of the tests. The rest of the output includes the project name and other things that are requested by the issue. +1 from me.

Kennric commented 8 years ago

Looks good to me. +1

matthewrsj commented 8 years ago

@athai is this good to merge?

athai commented 8 years ago

@matthewrsj Yes. Although, I was waiting to see if we wanted to handle parsing for the project name differently, but that can be resolved later.

Kennric commented 8 years ago

+1 again

ramereth commented 8 years ago

@athai I think this will work but I'd like to test it some more. Mind going ahead and merging this and if I run into anything new I'll make a new issue?