check_mx will perform unreliable DNS and network queries

osuosl / formsender

Simple script to email form submissions.

Apache License 2.0

3 stars 1 forks source link

check_mx will perform unreliable DNS and network queries #74

Closed jldugger closed 7 years ago

jldugger commented 7 years ago

We have a number of cases where DNS lookup has failed, at which point Formsender does not catch the exception thrown and the POST data is discarded. There's a number of ways to improve this code, but disabling the check is the fastest way of not dropping customer requests.

Reviewing the validate_email function, it does two optional things:

look for an MX record in DNS
send a RCPT request to the result of the MX lookup for the email address in question

This PR disables network validation of email addresses.

ramereth commented 7 years ago

@jldugger looks like you also need to update the tests.

jldugger commented 7 years ago

@ramereth before I go to the effort of deciphering the test suite, do people have showstopper objections to the solution?

ramereth commented 7 years ago

I have none from my perspective

jldugger commented 7 years ago

@ramereth fixed, and fixed a preexisting syntax error that was breaking CI.

jldugger commented 7 years ago

@Kennric thoughts?

knightsamar commented 7 years ago

Won't this be fixed with our new DNS server updates rolling in this week ?

ramereth commented 7 years ago

@knightsamar I'm not rolling that out this week. It's going to be several weeks out.

jldugger commented 7 years ago

@Kennric merged. What else do we need to do to push this change to production?