osuosl / formsender

Simple script to email form submissions.
Apache License 2.0
3 stars 1 forks source link

Removing unneeded files and updating docs #96

Closed agaetep closed 1 year ago

agaetep commented 1 year ago
  • I'm pretty sure __init__.py is required or is it because it's at the root?
  • Have you gone through each function to see if there is code we no longer need?

Yeah I think it is, I realized that during our meeting so I'll be adding it back in. I still haven't gone through the code itself

agaetep commented 1 year ago

Outside of my minor nitpick, does this PR require any changes in the cookbook? I think we can merge this/deploy this as-is and then we can update the cookbook later to properly setup Sentry.

With these changes, I don't think we will need to update any cookbooks since the Sentry uri isn't required. When we add Sentry to the container, we'll have to update the recipe to include the Sentry env variable in the docker container, which we need to add to the encrypted databag.