search

osuosl / orvsd_central

5 stars 2 forks source link

validate baseurl on input forms, disallow protocol string #130

Open Kennric opened 9 years ago

Kennric commented 9 years ago

Most of the code was written with the assumption that the baseurl field would omit the protocol string, and several things break if http:// is included - prevent this with form validation or strip the protocol on save

justinnoah commented 9 years ago

Progress pending discussion in #150

justinnoah commented 9 years ago

See https://github.com/orvsd/orvsd_central/issues/150#issuecomment-78147254 for specifics, though it looks like we are moving to a non-generic form which will make this easily possible.