search

osuosl / orvsd_central

5 stars 2 forks source link

Collapse course and CourseDetail #159

Closed justinnoah closed 9 years ago

justinnoah commented 9 years ago

fixes #152

Kennric commented 9 years ago

I don't see a migration to remove the old course_detail table, is that meant to be in this branch?

I believe you are removing the category field from the model, but this is not removed in the migration.

I'd like another set of eyes on this, just because there are a lot of opportunities for small errors.

justinnoah commented 9 years ago

@Kennric ready for more review

Kennric commented 9 years ago

This looks pretty good to me, but please have someone else run the migration and double-check - there are a lot of moving parts and it would be easy to miss something.

justinnoah commented 9 years ago

Assigned to @Chetco for review

Chetco commented 9 years ago

:+1: I've looked over the code and did some testing with a new cookbook using this branch.