osuosl / streamwebs

Streamwebs.org website
http://streamwebs.readthedocs.io/
4 stars 1 forks source link

Ensure all CSV export views are exporting all data #519

Open ramereth opened 6 years ago

ramereth commented 6 years ago

I noticed while working on another issue that the CSV export views didn't include some of the changes from #509. This made me wonder if we should go through and verify that all of the recent changes to the various views have also been carried to the export views properly.

hertelc commented 6 years ago

Found that exporting Water Quality includes more data than the site selected. See attached export from "Wenaha River" http://streamwebs.org/sites/wenaha-river/#3 WenahaRiver_Export_LiveSite.xlsx

CarvellWakeman commented 6 years ago

I'm not sure if my understanding of this bug is correct. Does this sound right?

Let there be an example site creek, which has 40 data sheets from 12 different schools. Let there be 4 water quality sheets from school A Let there be 3 water quality sheets from school B Let there be 10 macroinvertebrate sheets from school C (and no other macro sheets at all)

When exporting water quality data, you expect 7 rows, 4 coming from school A, and 3 coming from school B? But currently there are less than 7 rows in the exported data sheet?

hertelc commented 6 years ago

Have you tried doing a few exports for Water Quality? What I was seeing lately was data for multiple sites in the same sheet.

On Dec 29, 2017 5:39 PM, Zach Lerew notifications@github.com wrote:

I'm not sure if my understanding of this bug is correct. Does this sound right?

Let there be an example site creek, which has 40 data sheets from 12 different schools. Let there be 4 water quality sheets from school A Let there be 3 water quality sheets from school B Let there be 10 macroinvertebrate sheets from school C (and no other macro sheets at all)

When exporting water quality data, you expect 7 rows, 4 coming from school A, and 3 coming from school B? But currently there are less than 7 rows in the exported data sheet?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/osuosl/streamwebs/issues/519#issuecomment-354520643, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATYcky0N7BKSbzg_yEDzugaScm4iFnzLks5tFZRPgaJpZM4QMBOK.

hertelc commented 6 years ago

Also there have been several issues with the exports so really just need to open them all and make sure they are fully populating. At one point, yes not all data was included in the exports.

On Dec 29, 2017 5:39 PM, Zach Lerew notifications@github.com wrote:

I'm not sure if my understanding of this bug is correct. Does this sound right?

Let there be an example site creek, which has 40 data sheets from 12 different schools. Let there be 4 water quality sheets from school A Let there be 3 water quality sheets from school B Let there be 10 macroinvertebrate sheets from school C (and no other macro sheets at all)

When exporting water quality data, you expect 7 rows, 4 coming from school A, and 3 coming from school B? But currently there are less than 7 rows in the exported data sheet?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/osuosl/streamwebs/issues/519#issuecomment-354520643, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATYcky0N7BKSbzg_yEDzugaScm4iFnzLks5tFZRPgaJpZM4QMBOK.

CarvellWakeman commented 6 years ago

@hertelc I was not able to get data from multiple sites on any of the CSV exports. Still have to check and make sure that all expected data is in the export though.

hertelc commented 6 years ago

I just added a test site on production and a water quality datasheet. I then did an export and its still huge. The site is named "Delete Me - Test Site" I am deleting this site, but what is interesting is if you export the water quality data from the Wenaha River site, my Delete test site is at the bottom of the list... It almost looks like data as of a certain time is what is populating in this export. Since September 2017.

WaterQualityExport_DeleteMe.xlsx WaterQualityExport_Wenaha.xlsx

NathanTan commented 6 years ago

Data sheet exports that are fixed

hertelc commented 6 years ago

This looks good in staging. Closing issue.

hertelc commented 6 years ago

Tested on staging with Chrome. Water Quality is exporting too much information again. Reopening.

https://streamwebs-staging.osuosl.org/sites/wenaha-river/

jerry-peng commented 6 years ago

The bug is caused by different key used for relation between "water_quality_sample" and "water_quality" data during export.