All forms should have server side (only) validation. No client side pop-up validation. - Githubissues

osuosl / streamwebs

Streamwebs.org website

http://streamwebs.readthedocs.io/

4 stars 1 forks source link

All forms should have server side (only) validation. No client side pop-up validation. #575

Closed CarvellWakeman closed 6 years ago

CarvellWakeman commented 6 years ago

Use 'novalidate' property on form tag to do this. Make sure formModel is properly validated and form.is_valid() is being called in the controller

TODO

Datasheets

[X] Rip Aqua Survey
[x] Camera Point Add
[x] Canopy Cover Edit
[x] Macro Edit
[x] Photo Point Edit
[x] Photo Point View Add new photo section
[x] Riparian Transect
[x] Soil Edit
[x] Water Quality Edit
[x] Register
[x] Add account
[x] Edit account

Example image See #521 for example implementation

Testing:

Go to each form listed above, submit with bad data and again with blank data
See if border highlight is as expected
See if toast with errors shows up properly

CarvellWakeman commented 6 years ago

PR #533 has some stuff we can use for one of the forms.