osuosl / streamwebs

Streamwebs.org website
http://streamwebs.readthedocs.io/
4 stars 1 forks source link

Improve Login: Use Email where Possible, Username should not be Case Sensitive #586

Open hertelc opened 6 years ago

hertelc commented 6 years ago
hertelc commented 6 years ago

Talk with Mark before working on this please.

CarvellWakeman commented 6 years ago

Done with the parts that need to be in place before Jan 6th workshop

CarvellWakeman commented 6 years ago

Working on the remaining criteria in the bugfix/login_case branch

CarvellWakeman commented 6 years ago

@hertelc At some point soon I'm going to need an example email to send to users about the migration. I heard that there was a marketing email that someone else wanted to write up.

What needs to be done before this can go to prod: 1) I need an email template that the client wants sent to users to get them back on the site and let them know to log in with their email address. Can be HTML. 2) Duplicate emails need to be taken care of in the prod database before the bugfix/login_case branch is merged and deployed to prod. The migration will fail if there are duplicate users.

Both of these things are out of my control, so I'll be waiting to heard back on the progress before making a pull request. Let me know!

hertelc commented 6 years ago

Ok, I’ll work on getting these things ready to go. I’m going to have the Streamwebs folks come up with what they want for the email, so it may take a few days.

CARRIE HERTEL, PMP, CASS Director – SDG, TL, IoT Oregon State University | EECS/CASS | 541-737-6012 cass.oregonstate.edu

From: Zach Lerew [mailto:notifications@github.com] Sent: Monday, January 8, 2018 1:09 PM To: osuosl/streamwebs streamwebs@noreply.github.com Cc: Hertel, Carrie Lynn carrie.hertel@oregonstate.edu; Mention mention@noreply.github.com Subject: Re: [osuosl/streamwebs] Improve Login: Use Email where Possible, Username should not be Case Sensitive (#586)

@hertelchttps://github.com/hertelc At some point soon I'm going to need an example email to send to users about the migration. I heard that there was a marketing email that someone else wanted to write up.

What needs to be done before this can go to prod:

  1. I need an email template that the client wants sent to users to get them back on the site and let them know to log in with their email address. Can be HTML.
  2. Duplicate emails need to be taken care of in the prod database before the bugfix/login_case branch is merged and deployed to prod. The migration will fail if there are duplicate users.

Both of these things are out of my control, so I'll be waiting to heard back on the progress before making a pull request. Let me know!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/osuosl/streamwebs/issues/586#issuecomment-356096939, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATYckwmLsK3TG-dvz2GjrbO4pzCifWcmks5tIoPYgaJpZM4RGIoZ.

CarvellWakeman commented 6 years ago

Also, to keep stuff consolidated, here are the duplicate users. Renee Oneill Tanner Peticolas AND the three super admin accounts (admin, Admin, osladmin)

hertelc commented 6 years ago

@ramereth can we delete "Admin" and "osladmin"? It appears that "admin" is the only one with any actual admin privileges.

image

hertelc commented 6 years ago

@ramereth can you comment on the admin accounts referenced above please.

ramereth commented 6 years ago

@hertelc yes, I believe those were a hold over from the Drupal accounts.

hertelc commented 6 years ago

OK, I have deleted the extra Admin accounts and cleaned up the other two with duplicate emails so there should only be the 1. I did all of this in Production.

Tracy and Cait would like to send the email out AFTER doing the conversion for the usernames so they can make sure it is working ok before we send a bunch of people out to the site. @CarvellWakeman can you uncouple that piece?

CarvellWakeman commented 6 years ago

@hertelc the migration script for email to username contains a single function to send the email for each user as it processes them. It should be simple to remove it if you wanted Bailey or Jerry to take a look, since I'm on micromain. If that won't work I can do it tomorrow, just let me know.